Canyon Suite: A Comet project (for 6192)

84
Hello, for your latest changes I found two bugs, one when removing the garment and another when removing the garment from coat storage

Fix:

Long.Kernel\States\Storage\CoatStorage.cs Line 113

Code: Select all

public async Task<bool> UnequipCoatAsync(Item.ItemPosition itemPosition, RemovalType mode = RemovalType.RemoveOnly)
{
    var item = user.UserPackage.GetEquipment(itemPosition);
    if (item == null)
    {
        return false;
    }

	await user.SendAsync(new MsgCoatStorage(item.Identity, item.Type, 0, CoatStorageAction.UnequipWrap));

	if (mode == RemovalType.Delete)
    {
        await item.DeleteAsync();
    }
    else
    {
        item.Position = Item.ItemPosition.CoatStorage;
        await item.SaveAsync();
    }
    await user.SendAsync(new MsgItemInfo(item));
    await user.UserPackage.SyncEquipmentAsync();
    await user.Screen.BroadcastRoomMsgAsync(new MsgPlayer(user), false);
    await user.SendAsync(new MsgPlayerAttribInfo(user));
    return true;
}
Long.Kernel\Network\Game\Packets\MsgCoatStorage.cs Line 42

Code: Select all

public MsgCoatStorage(uint idItem, uint idData, uint life, CoatStorageAction action)
    : base(PacketType.MsgCoatStorage)
{
    Data = new MsgCoatStoragePB()
    {
        Action = (uint)action,
        ItemId = idItem,
		Data = idData,
		Life = life
    };
}
I hope it helps

not found UserCheckInItemToCoatStorage && UserCheckOutItemFromCoatStorage lua scripts

PS: I couldn't include the monster and attack system :(

Canyon Suite: A Comet project (for 6192)

85
thesamuraivega wrote: Thu Jul 11, 2024 4:01 am Hello, for your latest changes I found two bugs, one when removing the garment and another when removing the garment from coat storage
I hope it helps
not found UserCheckInItemToCoatStorage && UserCheckOutItemFromCoatStorage lua scripts
PS: I couldn't include the monster and attack system :(
I still didnt finish the CoatStorage and TitleStorage implementations, they changed a lot already since my last commit, I wouldn't pull feature branches before they're merged on develop or main xD but ty, I'll take a look at it tonight.

About those LUAs, I got them from the BXZF lua scripts which target 7117, I'm doing some cherry picks on stuff that I think that are on the 6270 version, so if you have higher versions of LUA you'll probably need to get it from there. The 7117 LUA Scripts is almost fully compatible with Long and Canyon, except for some NPC/Item entry points that will have minor changes.
Image

Don't PM me, I won't give Canyon 6192 complete lua or database.